chore: remove duplicate header check during initialization #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a description. More about this change as we discussed offline. It would be nice to mention how it is redundant (link to the code as well). |
|
/gcbrun |
|
/gcbrun |
|
@Ganga4060 can you make sure that the tests pass? |
f73af97 to
10511ed
Compare
|
/gcbrun |
twishabansal
approved these changes
Sep 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the strict
ValueErrorcheck for conflicting header names from the__init__method of theToolboxToolclass.Why is this change needed?
The strict check during initialization was contradictory to the actual runtime behavior in the
__call__method. The__call__method already contains a safe and predictable override logic.This change removes the initial check, making the "override" behavior the consistent and officially supported feature.
Redundancy of the Removed Check
The
ValueErrorcheck was redundant because the override logic in the__call__method already provides a clear and safe way to handle conflicts. The auth token headers are processed after the client headers, allowing them to take precedence.Link for strict check
tool.py