fix: Index store adds interface methods #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dishaprakash
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in #116 are failing because anew abstract methods were added (
async_index_structsandasync_add_index_struct) inBaseIndexStore. We already have implementations for those methods, but the new methods diverge from naming scheme ofa<method_name>and instead doasync_<method_name>for async methods. So, in this change, the new base methods are mapped using adapter pattern.This change was added in llama-index-core v0.12.36, which show sup on pypi but not yet in llama-index-core's releases history on the GH repo.
Latest release is still old on GH repo
Latest release is new on PyPI