Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

feat: Adds support for configuring scaling settings #232

Merged
gcf-merge-on-green merged 7 commits into from
Aug 25, 2022
Merged

feat: Adds support for configuring scaling settings #232

gcf-merge-on-green merged 7 commits into from
Aug 25, 2022

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Aug 23, 2022 •
edited
Loading

  • Regenerate this pull request now.

Clients can now specify machine type and min/max instances when creating a connector.

PiperOrigin-RevId: 469463049

Source-Link: googleapis/googleapis@17b39f1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/88b74ac69e76791a020cb543747c090655ee7144
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODhiNzRhYzY5ZTc2NzkxYTAyMGNiNTQzNzQ3YzA5MDY1NWVlNzE0NCJ9

@gcf-owl-bot
feat: Adds support for configuring scaling settings
052e1df 
Clients can now specify machine type and min/max instances when creating a connector.

PiperOrigin-RevId: 469463049

Source-Link: googleapis/googleapis@17b39f1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/88b74ac69e76791a020cb543747c090655ee7144
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODhiNzRhYzY5ZTc2NzkxYTAyMGNiNTQzNzQ3YzA5MDY1NWVlNzE0NCJ9
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner August 23, 2022 16:49
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 23, 2022
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Aug 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2022
@product-auto-label product-auto-label bot added the api: vpcaccess Issues related to the googleapis/java-vpcaccess API. label Aug 23, 2022
@snippet-bot
Copy link

snippet-bot bot commented Aug 23, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2022
@lqiu96 lqiu96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2022
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Aug 24, 2022

Owl bot is regenerating pull request 232...
Build name: NDM1MGZmYTctMjZiNi00NTU0LTg2NTAtZWRmZTI4NTE5ZmY0

@gcf-owl-bot
feat: Adds support for configuring scaling settings
7c6e394 
Clients can now specify machine type and min/max instances when creating a connector.

PiperOrigin-RevId: 469463049

Source-Link: googleapis/googleapis@17b39f1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/88b74ac69e76791a020cb543747c090655ee7144
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODhiNzRhYzY5ZTc2NzkxYTAyMGNiNTQzNzQ3YzA5MDY1NWVlNzE0NCJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2022
@gcf-merge-on-green
Copy link

gcf-merge-on-green bot commented Aug 24, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 24, 2022
@lqiu96
Copy link
Member

lqiu96 commented Aug 25, 2022

Tests require LocationsImplBase which come from LocationGrpc in the grpc library of java-common-protos (https://github.com/googleapis/java-common-protos). Going to include grpc-google-common-protos artifactId (version should be set properly in the first-party-dependencies bom.xml inside shared-dependencies lib.

https://github.com/googleapis/java-common-protos/blob/main/grpc-google-common-protos/src/main/java/com/google/cloud/location/LocationsGrpc.java

https://cloud.google.com/java/docs/reference/proto-google-common-protos/latest/com.google.cloud.location.LocationsGrpc.LocationsImplBase

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 25, 2022
@lqiu96 lqiu96 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 90f3253 into main Aug 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch August 25, 2022 21:12
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2022
@release-please release-please bot mentioned this pull request Aug 25, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 16, 2022
@release-please
chore(main): release 2.4.0 (#233)
a48b7ac 
🤖 I have created a release *beep* *boop*
---


## [2.4.0](v2.3.2...v2.4.0) (2022-09-15)


### Features

* Adds support for configuring scaling settings ([#232](#232)) ([90f3253](90f3253))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#235](#235)) ([3aa1c0a](3aa1c0a))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#237](#237)) ([34c930c](34c930c))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to meltsufin/monorepo-experiments that referenced this pull request Sep 17, 2022
@release-please
chore(main): release 2.4.0 (#233)
dcf9506 
🤖 I have created a release *beep* *boop*
---


## [2.4.0](googleapis/java-vpcaccess@v2.3.2...v2.4.0) (2022-09-15)


### Features

* Adds support for configuring scaling settings ([#232](googleapis/java-vpcaccess#232)) ([953c975](googleapis/java-vpcaccess@953c975))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#235](googleapis/java-vpcaccess#235)) ([204463f](googleapis/java-vpcaccess@204463f))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#237](googleapis/java-vpcaccess#237)) ([fcc31d1](googleapis/java-vpcaccess@fcc31d1))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lqiu96 lqiu96 lqiu96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: vpcaccess Issues related to the googleapis/java-vpcaccess API. owl-bot-copy size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lqiu96 @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.