Implementing get_multi in datastore. #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes distinction between an iterable of keys and a single key for get requests and re-purposes the get() name for the single key case. Fixes googleapis#701.
|
LGTM |
|
@tseaver Care to weigh in? |
|
Sorry -- I figured since I asked for it an @jgeewax OK'ed it, you were good to go. LGTM. |
dhermes
added a commit
that referenced
this pull request
May 26, 2015
Implementing get_multi in datastore.
|
@tseaver No worries. It wasn't pressing and I wanted to give you a chance to weigh in if you had any thoughts. |
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes distinction between an iterable of keys and a single
key for get requests and re-purposes the get() name for the
single key case.
Fixes #701.