Making Blob.exists() work as Bucket.exists(). #862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also returning the _BucketIterator directly in
storage.api.list_buckets() rather than wrapping it in iter().
@tseaver As mentioned #812 (comment) I said I'd fix
Blob.exists()
while making sure the iterators didn't work in batches.It turns out they were already not working. Here is a working get request
while a bucket iterator fails since
_FutureDict.get
throws aKeyError
:and a blob iterator fails (but not quite always)