Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

For consistency, replace all use of project_id w/ project. #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2015
Merged

For consistency, replace all use of project_id w/ project. #849

merged 2 commits into from
Apr 30, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 29, 2015

Also, rename regression_utils.get_environ -> check_environ, and drop return value (which only caller was ignoring).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2015
@tseaver tseaver added testing hygiene api: pubsub Issues related to the Pub/Sub API. labels Apr 29, 2015
@dhermes
Copy link
Contributor

dhermes commented Apr 29, 2015

LGTM. How did you come across this?

@tseaver
Copy link
Contributor Author

tseaver commented Apr 29, 2015

I was trying to find out how / where we were using / setting project, and accidentally typed git grep project_id=, finding many fewer locations than I expected.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bede80f on tseaver:squelch-project_id into d21bc3f on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Apr 30, 2015
@tseaver
Merge pull request #849 from tseaver/squelch-project_id
fb59514 
For consistency, replace all use of `project_id` w/ `project`.
@tseaver tseaver merged commit fb59514 into googleapis:master Apr 30, 2015
@tseaver tseaver deleted the squelch-project_id branch April 30, 2015 03:54
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @coveralls @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.