Fix regression3 failures in pubsub #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tseaver
commented
Apr 7, 2015
- Message payload must be bytes, base64ed, but then must be serializable to JSON.
- Likewise, 'attributes' values must be serializable to JSON.
- Message payload must be bytes, base64ed, but then must be serializable to JSON. - Likewise, 'attributes' values must be serializable to JSON.
|
See https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/57429797 |
|
Changes Unknown when pulling 9fade02 on tseaver:pubsub-fix_regression-py3k_bytes_attr into * on GoogleCloudPlatform:master*. |
|
Yup -- I just didn't look down far enough to see it. Should I merge? |
|
Was still mid-review. LGTM. |
tseaver
added a commit
that referenced
this pull request
Apr 7, 2015
…_attr Fix regression3 failures in pubsub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.