Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove Bucket.new_blob #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2015
Merged

Remove Bucket.new_blob #725

merged 2 commits into from
Mar 17, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 13, 2015

Was not necessary, Blob() constructor suffices.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 13, 2015
dhermes added 2 commits March 13, 2015 16:45
Updated Bucket.get_blob() and Bucket.delete_blob() to just take
a string instead of string or Blob. Logic being that if the user
already has a Blob, they can just call blob.delete() or
blob._reload_properties() (more convenient method needed).

Updated Bucket.delete_blobs() to check if each element in list of `blobs`
is a string or a Blob.

Updated Blob.delete() to call Bucket.delete_blob() with just a string and
updated Blob.rename() to call Blob.delete() instead of re-implementing the
mapping to Bucket.delete_blob().

Removed Test_Bucket.test_new_blob_existing, the last caller of
Bucket.new_blob that sends a Blob instead of a string.
Opting to just use Blob() constructor where relevant.
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 13, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d981af6 on dhermes:remove-new-blob into d668044 on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d981af6 on dhermes:remove-new-blob into d668044 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Mar 16, 2015

LGTM

dhermes added a commit that referenced this pull request Mar 17, 2015
@dhermes dhermes merged commit 6d147c8 into googleapis:master Mar 17, 2015
@dhermes dhermes deleted the remove-new-blob branch March 17, 2015 02:56
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 17, 2015
dhermes added a commit that referenced this pull request Mar 17, 2015
Fixing regression failure introduced in #725.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.