Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

DO NOT MERGE: logging synth (enums order only) #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: logging synth (enums order only) #6357

wants to merge 1 commit into from

Conversation

dpebot
Copy link
Contributor

@dpebot dpebot commented Nov 1, 2018

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/logging/artman_logging.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/logging-v2.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/logging_v2/proto/logging_pb2.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/logging_v2/proto/logging_metrics_pb2.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/logging_v2/proto/log_entry_pb2.py.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/logging_v2/proto/logging_config_pb2.py.
synthtool > Cleaned up 0 temporary directories.

@dpebot dpebot requested a review from crwilcox as a code owner November 1, 2018 12:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2018
@tseaver tseaver added api: logging Issues related to the Cloud Logging API. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 1, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 1, 2018

The only change here is to order of enums (see googleapis/gapic-generator#2319). I'm leaving it open, but marked do not merge, until a fix for that bug lands, at which point we can close this one and let @dpebot generate anew.

@tseaver tseaver added the status: blocked Resolving the issue is dependent on other work. label Nov 1, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated logging to pick up changes in the API or client library generator. DO NOT MERGE: logging synth (enums order only) Nov 1, 2018
@tseaver tseaver mentioned this pull request Nov 7, 2018
Merged
@tseaver tseaver closed this in #6435 Nov 7, 2018
tseaver added a commit that referenced this pull request Nov 7, 2018
@tseaver
Fix client_info bug, update docstrings via synth. (#6435)
d77c3c8 
Closes #6357.
@tseaver tseaver deleted the autosynth-logging branch November 7, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpebot @tseaver @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.