Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Error_reporting: prep docs for repo split. #6155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2018
Merged

Error_reporting: prep docs for repo split. #6155

merged 2 commits into from
Oct 17, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 3, 2018 •
edited
Loading

  • Harmonize / DRY README.rst / docs/index.rst
  • Move from docs/error-reporting -> error_reporting/docs, leaving a symlink with the old name.
  • Make the error_reporting/docs/usage.rst page only do usage: the rest is now in error_reporting/docs/index.rst.

Toward #5912.

@tseaver tseaver added documentation api: clouderrorreporting Issues related to the Error Reporting API. labels Oct 3, 2018
@tseaver tseaver requested a review from theacodes October 3, 2018 17:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2018
@tseaver tseaver mentioned this pull request Oct 3, 2018
Closed
31 tasks
@tseaver tseaver changed the title Error_reporting: harmonize / DRY 'README.rst' / 'docs/index.rst' Error_reporting: prep docs for repo split. Oct 3, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 3, 2018

Error reporting Kokoro systest failure tracked in #6157. Given that this is a docs-only change ("no docstrings were harmed in the making of this picture"), the relevant CI is still Circle (for the docs build), which is green.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 9, 2018

Rebased to pick up the PROJECT_ID fix from #6167.

tseaver added 2 commits October 9, 2018 11:44
@tseaver
Harmonize / DRY 'error_reporting/README.rst' / 'error_reporting/docs/…
71b18dc 
…index.rst'.

Toward #5912.
@tseaver
Move 'docs/error-reporting/*' -> 'error_reporting/docs/'.
b4f7093 
Leave behind a symlink (note its name uses a hyphen rather than an
underscore).

Make the 'usage.rst' page only do usage docs -- the rest is in 'index.rst'.
@tseaver tseaver requested a review from crwilcox October 9, 2018 19:15
@tseaver
Copy link
Contributor Author

tseaver commented Oct 9, 2018

@crwilcox, @theacodes This should be ready for review.

@tseaver tseaver merged commit ec5e02e into googleapis:master Oct 17, 2018
@tseaver tseaver deleted the 5912-error_reporting-prep_docs_for_repo_split branch October 17, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes Awaiting requested review from theacodes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: clouderrorreporting Issues related to the Error Reporting API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tseaver @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.