Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Parse 'LogEntry.receiveTimestamp' -> 'received_timestamp' attr. #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Parse 'LogEntry.receiveTimestamp' -> 'received_timestamp' attr. #6143

wants to merge 2 commits into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 1, 2018

Closes #5601.

@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Oct 1, 2018
@tseaver tseaver requested a review from theacodes as a code owner October 1, 2018 20:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 1, 2018

Logging system tests flake in _list_entries (see the ever-revenant #5303).

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2018
@tseaver tseaver force-pushed the 5601-logging-add_entry_received_timestamp branch from 19955e1 to fd93f96 Compare October 2, 2018 21:24
@tseaver
Copy link
Contributor Author

tseaver commented Oct 2, 2018

Rebased to trigger a new build.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 2, 2018

/cc @qingling128

@tseaver tseaver removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2018
@qingling128
Copy link
Contributor

@tseaver - Oh, great! Glad to see this being added. Thanks for the heads up! 👍

@tseaver tseaver force-pushed the 5601-logging-add_entry_received_timestamp branch 2 times, most recently from c8723aa to 0610e1f Compare October 9, 2018 18:19
@tseaver
Copy link
Contributor Author

tseaver commented Oct 9, 2018

Rebased to pick up the various logging systest flakiness fixes landed today.

@tseaver tseaver force-pushed the 5601-logging-add_entry_received_timestamp branch from 0610e1f to 3e90aa1 Compare October 9, 2018 18:46
@tseaver tseaver requested a review from crwilcox October 9, 2018 19:14
@tseaver
Copy link
Contributor Author

tseaver commented Oct 9, 2018

@crwilcox, @theacodes This should be ready for review.

@tseaver tseaver force-pushed the 5601-logging-add_entry_received_timestamp branch from 3e90aa1 to 35d69e6 Compare October 16, 2018 14:55
@tseaver tseaver mentioned this pull request Oct 16, 2018
Closed
@tseaver
Make 'received_timestamp' default to 'None' for all instances.
335d569 
It is set only when parsing a server response.
@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

Closing in favor of #6229, which includes these commits, but also adds other missing log entry fields, and refactors google.cloud.logging.entries to use named tuples.

@tseaver tseaver closed this Oct 17, 2018
@tseaver tseaver deleted the 5601-logging-add_entry_received_timestamp branch October 17, 2018 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @qingling128 @crwilcox @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.