Making sure bucket delete does not fail in regression tests. #563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
safe_delete()
which respects objects which are still listed for a bucket but have already been deleted. (This is because the object list is eventually consistent and we delete some objects in our regression tests.)Fixes #531. See #535 for context.
Fix based on comment from @thobrla.
This is a "temporary" stop-gap and the safe delete can likely be folded into
Connection.delete_bucket()
. For now, we want to eliminate flaky regression test failures.