Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Release monitoring 0.31.0 #5603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

crwilcox
Copy link
Contributor

This pull request was generated using releasetool.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2018
@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: monitoring Issues related to the Cloud Monitoring API. labels Jul 12, 2018
@tseaver
Copy link
Contributor

tseaver commented Jul 12, 2018

@crwilcox We have broken monitoring system tests from the merge of #5594.

@crwilcox
Copy link
Contributor Author

@tseaver interesting. I will look into this first thing tomorrow. I thought I ran the system tests but perhaps I did it before being finished. Thanks!

@tseaver
Copy link
Contributor

tseaver commented Jul 13, 2018

@crwilcox One think you might not know: in CI, we don't run system tests for PRs created against branches in forked repos, because of worries about exposing secrets. So, for any test which touches system tests, it is better to push the branch to this repo, rather than the fork, in order to let CI help catch things before merging.

@tseaver
Copy link
Contributor

tseaver commented Jul 13, 2018

#5608 fixes the breakage. I don't know whether this PR should be closed, and a new one generated, or whether just rebasing would work fine (the changelog might need updating?)

@tseaver
Copy link
Contributor

tseaver commented Jul 13, 2018

Superseded by #5616.

@tseaver tseaver closed this Jul 13, 2018
@crwilcox crwilcox deleted the release-monitoring-0.31.0 branch July 16, 2018 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.