Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Generate text-to-speech v1 and v1beta1 #5468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2018
Merged

Generate text-to-speech v1 and v1beta1 #5468

merged 3 commits into from
Jun 12, 2018

Conversation

theacodes
Copy link
Contributor

No description provided.

@theacodes theacodes requested a review from crwilcox June 11, 2018 19:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2018
@tseaver
Copy link
Contributor

tseaver commented Jun 11, 2018

I guess 0.1.0 is the ideal time to be making such a breaking change, but I thought we were versioning our APIs so that people could migrate their code in place, piecemeal, using the upgraded package (i.e., leaving older API version sub-packages around for at least a couple of releases).

@theacodes
Copy link
Contributor Author

@tseaver indeed, but yeah, this is a super early library so we opted to just s/v1beta/v1.

tseaver
tseaver suggested changes Jun 11, 2018
View reviewed changes
texttospeech/google/cloud/texttospeech_v1/types.py
http_pb2,
cloud_tts_pb2,
descriptor_pb2,
):

This comment was marked as spam.

Sign in to view

@theacodes theacodes changed the title Generate text-to-speech v1, remove v1beta Generate text-to-speech v1 and v1beta1 Jun 11, 2018
@theacodes theacodes merged commit ef9dd47 into master Jun 12, 2018
@theacodes theacodes deleted the texttospeech-v1 branch June 12, 2018 16:07
@tseaver tseaver mentioned this pull request Aug 28, 2018
Closed
parthea pushed a commit that referenced this pull request Sep 22, 2023
@theacodes
Generate text-to-speech v1 and v1beta1 (#5468)
72755fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver requested changes

@crwilcox crwilcox crwilcox approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theacodes @tseaver @crwilcox @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.