Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 8, 2015

Toward #514.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5f28d27 on tseaver:disuse_connection_save_delete_from_batch into 7c01fcc on GoogleCloudPlatform:master.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2015

@tseaver

  1. This is just a part of the third bullet in Decouple Transaction from Connection #514? I.E., slowly reduce dependencies on save_entity() and delete_entities()?
  2. ISTM delete() and put() are ready to go in datastore.api as you outlined in Push batch / transaction onto a thread-local stack inside 'with'. #518, yes? I can do that if you like or just sit back and watch.

Mostly LGTM other than small comments

@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Jan 9, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Jan 12, 2015

@dhermes: rebased / updated to address your concerns in 8bd5059. PTAL.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8bd5059 on tseaver:disuse_connection_save_delete_from_batch into 0525530 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Jan 12, 2015

One concern still dangling at

     if auto_id:
         insert = mutation_pb.insert_auto_id.add()
         auto_id_entities.append(entity)
     else:
         insert = mutation_pb.upsert.add()

Can you add a comment above here explaining that we don't use insert or update
but are aware of their existence and may add in future?


Can you address my two questions above? See #527 regarding point 2) above.

@tseaver
Copy link
Contributor Author

tseaver commented Jan 12, 2015

Good catch: 0525530 has the comment, which I hadn't saved to disk :(.

WRT #527: I really don't want to have begin() moved outside the context manager: it removes most of the point of the CM in the first place.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6af6e6d on tseaver:disuse_connection_save_delete_from_batch into 0525530 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Jan 12, 2015

LGTM

tseaver added a commit that referenced this pull request Jan 12, 2015
…om_batch

Factor out mutation-setting logic from 'Connection'.
@tseaver tseaver merged commit 51c1069 into googleapis:master Jan 12, 2015
@tseaver tseaver deleted the disuse_connection_save_delete_from_batch branch January 12, 2015 21:34
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Jan 12, 2015
Behavior of test_batch._Connection changed in googleapis#524.
parthea pushed a commit that referenced this pull request Aug 15, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
…message + enable default `_` recognizer (#524)

* feat: add `model` and `language_codes` fields in `RecognitionConfig` message + enable default `_` recognizer

Enables specifying `model` and `language_codes` in requests without having to specify them in the Recognizer (they can still be specified in the Recognizer in the `default_recognition_config` field).

Also enables using the recognizer ID `_` to perform recognition without explicitly creating a Recognizer resource.

The top-level `model` and `language_codes` fields are deprecated in favor of the new fields added in the `RecognitionConfig` message. The old fields continue to work.

PiperOrigin-RevId: 545698919

Source-Link: googleapis/googleapis@e73fc8f

Source-Link: googleapis/googleapis-gen@b77dfdf
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjc3ZGZkZmUzOTI3ZTQwOTg3NWIyZDg5MTNmMjU3NGZhMDBhMDVhNSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 26, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [rsa](https://stuvel.eu/rsa) ([source](https://togithub.com/sybrenstuvel/python-rsa)) | minor | `>=3.1.4,<4.1` -> `>=3.1.4,<4.2` |

---

### Release Notes

<details>
<summary>sybrenstuvel/python-rsa</summary>

### [`v4.1`](https://togithub.com/sybrenstuvel/python-rsa/blob/master/CHANGELOG.md#Version-41---released-2020-06-10)

-   Added support for Python 3.8.
-   Dropped support for Python 2 and 3.4.
-   Added type annotations to the source code. This will make Python-RSA easier to use in
    your IDE, and allows better type checking.
-   Added static type checking via [MyPy](http://mypy-lang.org/).
-   Fix [#&#8203;129](https://togithub.com/sybrenstuvel/python-rsa/issues/129) Installing from source
    gives UnicodeDecodeError.
-   Switched to using [Poetry](https://poetry.eustace.io/) for package
    management.
-   Added support for SHA3 hashing: SHA3-256, SHA3-384, SHA3-512. This
    is natively supported by Python 3.6+ and supported via a third-party
    library on Python 3.5.
-   Choose blinding factor relatively prime to N. Thanks Christian Heimes for pointing this out.
-   Reject cyphertexts (when decrypting) and signatures (when verifying) that have
    been modified by prepending zero bytes. This resolves CVE-2020-13757. Thanks
    Adelapie for pointing this out.

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/google-auth-library-python).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.