Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add 'insert_auto_ids' support to 'Batch'. #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 5 commits into from
Jan 8, 2015
Merged

Add 'insert_auto_ids' support to 'Batch'. #515

tseaver merged 5 commits into from
Jan 8, 2015

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 8, 2015

Follow-on to #509.

@coveralls
Copy link

coveralls commented Jan 8, 2015

Coverage Status

Changes Unknown when pulling 6078fc1 on tseaver:509-add_insert_auto_id_support_to_batch into * on GoogleCloudPlatform:master*.

dhermes
dhermes reviewed Jan 8, 2015
View reviewed changes
gcloud/datastore/batch.py Outdated
self.connection.commit(self._dataset_id, self.mutation)
response = self.connection.commit(self._dataset_id, self.mutation)
for new_key_pb, entity in zip(response.insert_auto_id_key,
self._auto_id_entities):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2015

It looks fine but let's hear from Patrick before merging.

@tseaver
Add 'Batch.add_auto_id_entity' method.
d5d28c9 
FBO the proposed global 'put'.
@tseaver
Copy link
Contributor Author

tseaver commented Jan 8, 2015

Second commit adds a method, add_auto_id_entity, to Batch, so that external callers (e.g., Entity.save or datastore.put) can handle the batch like a transaction.

@coveralls
Copy link

coveralls commented Jan 8, 2015

Coverage Status

Changes Unknown when pulling de78a69 on tseaver:509-add_insert_auto_id_support_to_batch into * on GoogleCloudPlatform:master*.

dhermes
dhermes reviewed Jan 8, 2015
View reviewed changes
gcloud/datastore/batch.py Outdated
the entity has a partial key, it adds itself to the list of
entities to be updated once the transaction is committed by
calling this method.
"""

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Jan 8, 2015

I will wait for Patrick's reply.

@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2015

@tseaver He already replied, see my comment above.

@coveralls
Copy link

coveralls commented Jan 8, 2015

Coverage Status

Changes Unknown when pulling 6f12f16 on tseaver:509-add_insert_auto_id_support_to_batch into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

coveralls commented Jan 8, 2015

Coverage Status

Changes Unknown when pulling 5c10b10 on tseaver:509-add_insert_auto_id_support_to_batch into * on GoogleCloudPlatform:master*.

@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2015

LGTM.

The behavior of the Commit RPC is a relief :)

tseaver added a commit that referenced this pull request Jan 8, 2015
@tseaver
Merge pull request #515 from tseaver/509-add_insert_auto_id_support_t…
2b4f52f 
…o_batch

Add 'insert_auto_ids' support to 'Batch'.
@tseaver tseaver merged commit 2b4f52f into googleapis:master Jan 8, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Jan 8, 2015

Yup. I guess the difference is not "partial success" but rather "eventual consistency" (no guarantees that the change will be visible immediately).

@tseaver tseaver deleted the 509-add_insert_auto_id_support_to_batch branch January 8, 2015 18:53
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
parthea pushed a commit that referenced this pull request Aug 15, 2023
@gcf-owl-bot
docs: clarified wording around quota usage (#515)
3702497 
* docs: clarified wording around quota usage

PiperOrigin-RevId: 516225429

Source-Link: googleapis/googleapis@c13a985

Source-Link: googleapis/googleapis-gen@7bf5248
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmNTI0OGZhMWQ3MjQwMDZhNTg5ZTA3ZDkwMjk5NTFjNzRhOGJjNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update dependency flask to v2.1.2 (#515)
fb04067
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: fix prerelease_deps nox session [autoapprove] (#515)
4b0bd84 
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump certifi from 2022.12.7 to 2023.7.22 (#…
790b7f8 
…515)

Source-Link: https://togithub.com/googleapis/synthtool/commit/395d53adeeacfca00b73abf197f65f3c17c8f1e9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.0 (#515)
07be454
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): update release script dependencies (#515)
8b02c02 
Source-Link: googleapis/synthtool@25083af
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.2 (#515)
5c0e4b2 
* chore: Update gapic-generator-python to v1.8.2

PiperOrigin-RevId: 504289125

Source-Link: googleapis/googleapis@38a48a4

Source-Link: googleapis/googleapis-gen@b2dc226
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@release-please
chore(main): release 2.20.0 (#515)
2515213 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
@gcf-owl-bot
chore(python): add license header to auto-label.yaml (#515)
9581542 
Source-Link: googleapis/synthtool@eb78c98
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore: release 0.26.5 (#515)
e3d8bcf 
* updated CHANGELOG.md [ci skip]

* updated setup.py

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
build(deps): [autoapprove] bump pygments from 2.13.0 to 2.15.0 (#515)
193bfcc 
Source-Link: googleapis/synthtool@eaef28e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot @parthea
build(python): fix docs and docfx builds (#515)
fa78520 
* build(python): fix `docs` and `docfx` builds

Source-Link: googleapis/synthtool@fac8444
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5ea6d0ab82c956b50962f91d94e206d3921537ae5fe1549ec5326381d8905cfa

* exclude types-protobuf==4.24.0.20240106 release

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@yoshi-automation @busunkim96
chore: update file headers (#515)
c8d9afb 
* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* chore: modify synth excludes

Co-authored-by: Bu Sun Kim <busunkim@google.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: datastore Issues related to the Datastore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @coveralls @dhermes @pcostell
Morty Proxy This is a proxified and sanitized view of the page, visit original site.