Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix #121: don't copy project ID to the Key protobuf's dataset_id. #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silvolu merged 2 commits into from
Oct 22, 2014
Merged

Fix #121: don't copy project ID to the Key protobuf's dataset_id. #276

silvolu merged 2 commits into from
Oct 22, 2014

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 21, 2014

The back-end already knows it, and it is actually different than the 'project ID' we are assigning to the dataset as its ID.

See #121.

@dhermes
Copy link
Contributor

dhermes commented Oct 21, 2014

I'm going to let @pcostell review as the last time I LGTM'd with hesitation, something broke.

Can you rebase and verify that tox -e regression passes? (I'll clone your fork and do the same.)

@coveralls
Copy link

coveralls commented Oct 21, 2014

Coverage Status

Coverage remained the same when pulling 6e69f41 on tseaver:121-dont_copy_key_datasetid_to_pb into 7f6e4b1 on GoogleCloudPlatform:master.

@silvolu
Copy link
Contributor

silvolu commented Oct 21, 2014

I've just re-run the Travis build because it previously failed for some transient connectivity error, it's green now.

@pcostell
Copy link
Contributor

pcostell commented Oct 21, 2014

LGTM. Does the travis build run against a full production Cloud Datastore instance? It would be good to make sure that the dataset really does get populated, just in case.

@dhermes
Copy link
Contributor

dhermes commented Oct 21, 2014

@pcostell it doesn't quite yet, but we are about to add the regression tests to merge.sh which will be run every time a PR is merged.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 21, 2014

@dhermes where is the "how to run regression tests" bit running down? Should maybe be an entry in CONTRIBUTING.rst?

@dhermes
Copy link
Contributor

dhermes commented Oct 21, 2014

Yes, will be in a forthcoming PR.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 22, 2014

6b49d10 makes a further stab at preserving the key's dataset ID as set by the back-end, while not expecting / encouraging it to be set for new keys. It breaks the direct relationship from Key -> Dataset, replacing that with one from Entity -> Dataset.

I've rebased to test with 'tox -e regression': all five pass.

@tseaver tseaver added the api: datastore Issues related to the Datastore API. label Oct 22, 2014
@tseaver tseaver changed the title Fix #121: don't copy key's datset ID to the protobuf. Fix #121: don't copy key's dataset ID to the protobuf. Oct 22, 2014
@tseaver
Don't copy key's datset ID to the protobuf.
e78193b 
The back-end already knows it, and it is actually different than the
'project ID' we are assigning to the dataset as its ID.

Fixes #121.
@tseaver
Remove direct 'Key' -> 'Dataset' relationship.
c769cc7 
Replace it with an (optional) '_dataset_id' attribute, which is None for
newly-created keys, or the more-or-less opaque value set by the backend
for keys fetched from it.

Add direct 'Entity' -> 'Dataset' relationship (rather than indirecting
through the entity's key.

Addresses @pcostell's remarks on #259:

#259 (comment)
@tseaver
Copy link
Contributor Author

tseaver commented Oct 22, 2014

Rebased after merging #284 to master.

@tseaver tseaver changed the title Fix #121: don't copy key's dataset ID to the protobuf. Fix #121: don't copy project ID to the Key protobuf's dataset_id. Oct 22, 2014
@coveralls
Copy link

coveralls commented Oct 22, 2014

Coverage Status

Coverage remained the same when pulling c769cc7 on tseaver:121-dont_copy_key_datasetid_to_pb into c2a38fb on GoogleCloudPlatform:master.

silvolu added a commit that referenced this pull request Oct 22, 2014
@silvolu
Merge pull request #276 from tseaver/121-dont_copy_key_datasetid_to_pb
fe6e4fb 
Fix #121: don't copy project ID to the Key protobuf's dataset_id.
@silvolu silvolu merged commit fe6e4fb into googleapis:master Oct 22, 2014
@tseaver tseaver deleted the 121-dont_copy_key_datasetid_to_pb branch October 22, 2014 19:32
This was referenced Oct 22, 2014
Closed
Merged
@dhermes dhermes mentioned this pull request Oct 23, 2014
Merged
atulep pushed a commit that referenced this pull request Apr 6, 2023
@b-loved-dreamer
docs(samples): a draft that refactors speech_to_storage_beta sample (#…
6337eb3 
…276)

* docs(samples): a draft that refactors speech_to_storage_beta sample

* docs(samples): applied changes

* docs(samples): file name changed

* docs(samples): added new line eof

* docs(samples): updated to LongRunningRecognizeResponse

* docs(samples): fixed lint

* docs(samples): removed unwanted line

* docs(samples): removed unwanted line
atulep pushed a commit that referenced this pull request Apr 6, 2023
@b-loved-dreamer
docs(samples): a draft that refactors speech_to_storage_beta sample (#…
c1e70d3 
…276)

* docs(samples): a draft that refactors speech_to_storage_beta sample

* docs(samples): applied changes

* docs(samples): file name changed

* docs(samples): added new line eof

* docs(samples): updated to LongRunningRecognizeResponse

* docs(samples): fixed lint

* docs(samples): removed unwanted line

* docs(samples): removed unwanted line
atulep pushed a commit that referenced this pull request Apr 18, 2023
@b-loved-dreamer
docs(samples): a draft that refactors speech_to_storage_beta sample (#…
7eed55e 
…276)

* docs(samples): a draft that refactors speech_to_storage_beta sample

* docs(samples): applied changes

* docs(samples): file name changed

* docs(samples): added new line eof

* docs(samples): updated to LongRunningRecognizeResponse

* docs(samples): fixed lint

* docs(samples): removed unwanted line

* docs(samples): removed unwanted line
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#276)
71f04e5 
Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-pubsub to v2.13.12 (#276)
9f11094
parthea pushed a commit that referenced this pull request Jun 4, 2023
@busunkim96
fix: remove libcst from setup_requires (#276)
4db5614
parthea added a commit that referenced this pull request Jun 4, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#276)
a716d7a 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Jun 4, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#276)
9d2f70a 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: detect samples tests in nested directories (#276)
ac0252d 
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
parthea added a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot @parthea
fix(deps): Require google-api-core >=1.34.0, >=2.11.0 (#276)
3b9f046 
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0

fix: Drop usage of pkg_resources

fix: Fix timeout default values

docs(samples): Snippetgen should call await on the operation coroutine before calling result

PiperOrigin-RevId: 493260409

Source-Link: googleapis/googleapis@fea4387

Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add gapic_version.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
chore: make samples 3.6 check optional (#276)
9ef7999
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#276)
cd89190 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @parthea
chore(deps): update all dependencies to v2.11.1 (#276)
c69e308 
* chore(deps): update all dependencies to v2.11.1

* revert

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-auth to v2.2.1 (#276)
f56bfb3
parthea added a commit that referenced this pull request Sep 22, 2023
@parthea @gcf-owl-bot
chore: delete owlbot.py (#276)
0b3baa1 
* chore: delete owlbot.py

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): exclude grpcio==1.49.0rc1 in tests [autoapprove] (#276)
6989323 
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea added a commit that referenced this pull request Sep 22, 2023
@release-please @parthea
chore(main): release 2.10.0 (#276)
7295e89 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): update .pre-commit-config.yaml to use black==22.3.0 (#276
4481caf 
)

Source-Link: googleapis/synthtool@7804ade
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot @gcf-owl-bot
chore(deps): update all dependencies (#276)
f7c7ce9 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v6.2.5 (#276)
80eb544
parthea pushed a commit that referenced this pull request Oct 21, 2023
@m-strzelczyk
docs(samples): Improving snapshot samples (#276)
b7b9758 
Improving the code snippets for disk snapshots, so they can be used on this page: [Create and manage disk snapshots
](https://cloud.google.com/compute/docs/disks/create-snapshots)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(deps): update dependency pyupgrade to v2.32.1 (#276)
312663b 
Source-Link: googleapis/synthtool@35e1ea8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:73564f768388926a050a7a957650bfd1f584df6e0b3512e199a8e12d9dfc4618

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @busunkim96 @parthea
docs: add generated snippets (#276)
e5d9e5c 
* chore: use gapic-generator-python 0.63.2
docs: add generated snippets

PiperOrigin-RevId: 427792504

Source-Link: googleapis/googleapis@55b9e1e

Source-Link: googleapis/googleapis-gen@bf4e86b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmY0ZTg2Yjc1M2Y0MmNiMGVkYjFmZDUxZmJlODQwZDdkYTBhMWNkZSJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: use gapic-generator-python 0.63.4

chore: fix snippet region tag format
chore: fix docstring code block formatting
PiperOrigin-RevId: 430730865

Source-Link: googleapis/googleapis@ea58002

Source-Link: googleapis/googleapis-gen@ca893ff
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2E4OTNmZjhhZjI1ZmM3ZmUwMDFkZTE0MDVhNTE3ZDgwNDQ2ZWNjYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: delete duplicates

* restore async_client.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
fix: add model signature for batch document translation (#276)
23f17fc 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 403140062

Source-Link: googleapis/googleapis@67e6e0a

Source-Link: googleapis/googleapis-gen@779ead9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzc5ZWFkOTJjZGMyNDMzZDg0YWU1YWU1MzQxOGIxNjAwODQzMjI0ZSJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore: release 3.6.0 (#277)
34bc847 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.6.0](https://www.github.com/googleapis/python-translate/compare/v3.5.0...v3.6.0) (2021-10-18)


### Features

* add support for python 3.10 ([#275](https://www.github.com/googleapis/python-translate/issues/275)) ([381fc15](https://www.github.com/googleapis/python-translate/commit/381fc15cd920252edbc280b7623125955ee68347))


### Bug Fixes

* add model signature for batch document translation ([#276](https://www.github.com/googleapis/python-translate/issues/276)) ([be0b01b](https://www.github.com/googleapis/python-translate/commit/be0b01bb5b21cec9910967305784fc02c7ce83ff))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore: release 2.6.3 (#276)
11c6383 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.6.3](https://www.github.com/googleapis/python-vision/compare/v2.6.2...v2.6.3) (2021-12-12)


### Documentation

* Add example of how to use max_results ([#277](https://www.github.com/googleapis/python-vision/issues/277)) ([cf4dafe](https://www.github.com/googleapis/python-vision/commit/cf4dafe7c716c8091efd3bcc5a6fa5729c72fed3))
* Update doctext sample to include method signature ([#275](https://www.github.com/googleapis/python-vision/issues/275)) ([b059f3a](https://www.github.com/googleapis/python-vision/commit/b059f3a7b39a6f17c0086e18fc69776265de18d7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: regenerate samples (#276)
60fec23 
* feat: release SensitiveAction Cloud Logging payload to v1

PiperOrigin-RevId: 476083958

Source-Link: googleapis/googleapis@fafd03f

Source-Link: googleapis/googleapis-gen@79c1b9c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzljMWI5Y2UyNDMzNzQ3MzU2NTFlNzJjZGViY2JlZDk5ZjVlNGU2NSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): exclude grpcio==1.49.0rc1 in tests [autoapprove] (#276)
37a07eb 
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: [autoapprove] update readme_gen.py to include autoescape True (#…
9ea4006 
…276)

Source-Link: googleapis/synthtool@6b4d5a6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f792ee1320e03eda2d13a5281a2989f7ed8a9e50b73ef6da97fac7e1e850b149

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@b-loved-dreamer
docs(samples): a draft that refactors speech_to_storage_beta sample (#…
10e7732 
…276)

* docs(samples): a draft that refactors speech_to_storage_beta sample

* docs(samples): applied changes

* docs(samples): file name changed

* docs(samples): added new line eof

* docs(samples): updated to LongRunningRecognizeResponse

* docs(samples): fixed lint

* docs(samples): removed unwanted line

* docs(samples): removed unwanted line
parthea pushed a commit that referenced this pull request Oct 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.0 (#276)
fff5d5a
parthea pushed a commit that referenced this pull request Aug 21, 2025
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v2.24.1 (#276)
2e7e269
parthea pushed a commit that referenced this pull request Sep 16, 2025
@renovate-bot @parthea
chore(deps): update dependency google-cloud-bigquery to v2.24.1 (#276)
e2e3169
parthea pushed a commit that referenced this pull request Nov 22, 2025
@yoshi-automation
deps: upgrade gapic-generator-python to 0.43.1 (#276)
4f89e0b 
* build: use gapic-generator-typescript v1.2.11.

Fixed IAM v1 library generation.
Committer: @alexander-fenster
PiperOrigin-RevId: 361676678

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Mar 8 15:51:18 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 3aeb3a70f66457a9e6b07caff841719bb9873b57
Source-Link: googleapis/googleapis@3aeb3a7

* chore: upgrade gapic-generator-python to 0.43.1

PiperOrigin-RevId: 364411656

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Mar 22 14:40:22 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 149a3a84c29c9b8189576c7442ccb6dcf6a8f95b
Source-Link: googleapis/googleapis@149a3a8

* feat: add `kind` field which is used to distinguish between response types feat: add `potentially_thresholded_requests_per_hour` field to `PropertyQuota`

PiperOrigin-RevId: 365882072

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Mar 30 13:17:13 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 95dd24960cf9f794ef583e59ad9f1fabe1c4a924
Source-Link: googleapis/googleapis@95dd249
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore(main): release 1.6.2 (#276)
5962795 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@JustinBeckwith
build: use main branch (#276)
a73187f
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
build(deps): bump cryptography from 42.0.2 to 42.0.4 in .kokoro (#276)
6e4d79e 
Source-Link: googleapis/synthtool@d895aec
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:98f3afd11308259de6e828e37376d18867fd321aba07826e29e4f8d9cab56bad

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please @holtskinner
chore(main): release 0.13.3-alpha (#276)
18b30af 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore: release 2.1.0 (#276)
fe2b5c6 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: datastore Issues related to the Datastore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tseaver @dhermes @coveralls @silvolu @pcostell
Morty Proxy This is a proxified and sanitized view of the page, visit original site.