Implementing consume_*() methods on Bigtable PartialRowsData. #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| always | ||
| """ | ||
| raise NotImplementedError | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
These methods read from a stream of ReadRowsResponse's, parse them and then store them on the PartialRowsData instance.
659e34c to
3d98eb7
Compare
|
LGTM after the rebase/Travis. |
dhermes
added a commit
that referenced
this pull request
Feb 18, 2016
…data Implementing consume_*() methods on Bigtable PartialRowsData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods read from a stream of
ReadRowsResponse's, parse them and then store them on thePartialRowsDatainstance.@tseaver The implementation of
PartialRowData.update_from_read_rowsis coming soon. It depends on #1492. I held off on including it there because it has a non-trivial amount of code.