Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

#1424: Defend against missing 'datasets' key in datasets/list response. #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2016
Merged

#1424: Defend against missing 'datasets' key in datasets/list response. #1425

merged 1 commit into from
Jan 28, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 28, 2016

Fixes #1424.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigquery Issues related to the BigQuery API. labels Jan 28, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2016
dhermes
dhermes reviewed Jan 28, 2016
View reviewed changes
gcloud/bigquery/test_client.py
@@ -74,27 +74,11 @@ def test_list_datasets_defaults(self):
self.assertEqual(req['method'], 'GET')
self.assertEqual(req['path'], '/%s' % PATH)

def test_list_datasets_explicit(self):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jan 28, 2016

Can you also update the system_test as was done in #1421?

@tseaver
Copy link
Contributor Author

tseaver commented Jan 28, 2016

Can you also update the system_test as was done in #1421?

Tricky: Datasets are top-level objects, so it isn't guaranteed that there won't be any already existing for a given project.

@dhermes
Copy link
Contributor

dhermes commented Jan 28, 2016

Touche. Fine as is. I should have thought more than just the one tiny thought.

@dhermes
Copy link
Contributor

dhermes commented Jan 28, 2016

LGTM

tseaver added a commit that referenced this pull request Jan 28, 2016
@tseaver
Merge pull request #1425 from tseaver/1424-bigquery-missing_datasets_key
7b08a59 
#1424: Defend against missing 'datasets' key in datasets/list response.
@tseaver tseaver merged commit 7b08a59 into googleapis:master Jan 28, 2016
@tseaver tseaver deleted the 1424-bigquery-missing_datasets_key branch January 28, 2016 20:51
@dhermes dhermes mentioned this pull request Jan 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.