Streaming: add pep8 / pylint goodness #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Theres a bit more than PEP8 changes in "Get 'pep8' working on 'gcloud/streaming'." (e.g. dropping |
| return int(self.response['status']) | ||
|
|
||
| @classmethod | ||
| def FromResponse(cls, http_response): | ||
| def from_response(cls, http_response): | ||
| """Factory: construct an exception from a resopnse.""" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -812,7 +1155,7 @@ def _send_chunk(self, start): | ||
| end = body_stream.stream_end_position | ||
| if body_stream.stream_exhausted: | ||
| self.__total_size = end | ||
| # TODO: Here, change body_stream from a stream to a string object, | ||
| # Here, change body_stream from a stream to a string object, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Finished review |
|
LGTM |
tseaver
added a commit
that referenced
this pull request
Nov 19, 2015
Streaming: add pep8 / pylint goodness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses #1209 as a base.