Moving rename() from Blob to Bucket. #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fit the pattern already in place for Bucket.copy_blob. The philosophy being to treat copy and rename as operations associated with the container (Bucket) rather than with the object itself (Blob). Fixes googleapis#1007.
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Aug 12, 2015
Moving rename() from Blob to Bucket.
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jun 3, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ==
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jun 4, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ== feat: Update Compute Engine v1 API to revision 20250511 (#1047) Note that this contains an intended breaking change to MachineType.scratchDisks. Googlers: see cl/751378213 and b/416655944 Source-Link: googleapis/googleapis@a9f7da0 Source-Link: googleapis/googleapis-gen@5acff2f Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhY2ZmMmZmNDU1YTVlNjhiZjE3YjdlMDFjZGE0ZDcxNmNiZTAyMWYifQ==
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jun 5, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ== feat: Update Compute Engine v1 API to revision 20250511 (#1047) Note that this contains an intended breaking change to MachineType.scratchDisks. Googlers: see cl/751378213 and b/416655944 Source-Link: googleapis/googleapis@a9f7da0 Source-Link: googleapis/googleapis-gen@5acff2f Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhY2ZmMmZmNDU1YTVlNjhiZjE3YjdlMDFjZGE0ZDcxNmNiZTAyMWYifQ==
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jun 5, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ== feat: Update Compute Engine v1 API to revision 20250511 (#1047) Note that this contains an intended breaking change to MachineType.scratchDisks. Googlers: see cl/751378213 and b/416655944 Source-Link: googleapis/googleapis@a9f7da0 Source-Link: googleapis/googleapis-gen@5acff2f Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhY2ZmMmZmNDU1YTVlNjhiZjE3YjdlMDFjZGE0ZDcxNmNiZTAyMWYifQ==
gcf-owl-bot bot
added a commit
that referenced
this pull request
Jun 5, 2025
Source-Link: googleapis/googleapis@79d04b7 Source-Link: googleapis/googleapis-gen@08507bd Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjA4NTA3YmRiN2I4OTAyMWZmYTBjYjVlNzJhNzgxZjE2NWQ1N2MxZjcifQ== feat: Update Compute Engine v1 API to revision 20250511 (#1047) Note that this contains an intended breaking change to MachineType.scratchDisks. Googlers: see cl/751378213 and b/416655944 Source-Link: googleapis/googleapis@a9f7da0 Source-Link: googleapis/googleapis-gen@5acff2f Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6IjVhY2ZmMmZmNDU1YTVlNjhiZjE3YjdlMDFjZGE0ZDcxNmNiZTAyMWYifQ==
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fit the pattern already in place for Bucket.copy_blob. The philosophy being to treat copy and rename as operations associated with the container (Bucket) rather than with the object itself (Blob).
Fixes #1007.