Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c04d18d

Browse filesBrowse files
committed
Addressing review comments.
- Removing accidentally including bigquery module from IGNORED_MODULES in verify_include_modules - Adding Sphinx as a lint dependency (it couldn't be imported) - Fixing Python 2 style print statements in run_pylint
1 parent aafe3d1 commit c04d18d
Copy full SHA for c04d18d

File tree

Expand file treeCollapse file tree

3 files changed

+7
-7
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+7
-7
lines changed

‎scripts/run_pylint.py

Copy file name to clipboardExpand all lines: scripts/run_pylint.py
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -154,12 +154,12 @@ def get_files_for_linting(allow_limited=True):
154154
if diff_base is not None and allow_limited:
155155
result = subprocess.check_output(['git', 'diff', '--name-only',
156156
diff_base])
157-
print 'Using files changed relative to %s:' % (diff_base,)
158-
print '-' * 60
159-
print result.rstrip('\n') # Don't print trailing newlines.
160-
print '-' * 60
157+
print('Using files changed relative to %s:' % (diff_base,))
158+
print('-' * 60)
159+
print(result.rstrip('\n')) # Don't print trailing newlines.
160+
print('-' * 60)
161161
else:
162-
print 'Diff base not specified, listing all files in repository.'
162+
print('Diff base not specified, listing all files in repository.')
163163
result = subprocess.check_output(['git', 'ls-files'])
164164

165165
return result.rstrip('\n').split('\n'), diff_base
@@ -217,7 +217,7 @@ def lint_fileset(filenames, rcfile, description):
217217
print(error_message, file=sys.stderr)
218218
sys.exit(status_code)
219219
else:
220-
print 'Skipping %s, no files to lint.' % (description,)
220+
print('Skipping %s, no files to lint.' % (description,))
221221

222222

223223
def main():

‎scripts/verify_included_modules.py

Copy file name to clipboardExpand all lines: scripts/verify_included_modules.py
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
OBJECT_INVENTORY_RELPATH = os.path.join('_build', 'html', 'objects.inv')
3131
IGNORED_PREFIXES = ('test_', '_')
3232
IGNORED_MODULES = frozenset([
33-
'gcloud.bigquery.query',
3433
'gcloud.bigtable.client',
3534
'gcloud.bigtable.cluster',
3635
'gcloud.bigtable.column_family',

‎tox.ini

Copy file name to clipboardExpand all lines: tox.ini
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ deps =
7777
pylint
7878
unittest2
7979
psutil
80+
Sphinx
8081
passenv = {[testenv:system-tests]passenv}
8182

8283
[testenv:system-tests]

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.