Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3637cee

Browse filesBrowse files
committed
Add regression tests for 'Subscription.create'/'api.list_subscriptions'.
1 parent 2871795 commit 3637cee
Copy full SHA for 3637cee

File tree

Expand file treeCollapse file tree

2 files changed

+48
-9
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+48
-9
lines changed

‎gcloud/pubsub/__init__.py

Copy file name to clipboardExpand all lines: gcloud/pubsub/__init__.py
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
from gcloud.connection import get_scoped_connection
3030
from gcloud.pubsub import _implicit_environ
3131
from gcloud.pubsub._implicit_environ import get_default_connection
32+
from gcloud.pubsub.api import list_subscriptions
3233
from gcloud.pubsub.api import list_topics
3334
from gcloud.pubsub.connection import Connection
3435

‎regression/pubsub.py

Copy file name to clipboardExpand all lines: regression/pubsub.py
+47-9Lines changed: 47 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,15 @@
1818

1919
from gcloud import _helpers
2020
from gcloud import pubsub
21+
from gcloud.pubsub.subscription import Subscription
2122
from gcloud.pubsub.topic import Topic
2223

2324

2425
_helpers._PROJECT_ENV_VAR_NAME = 'GCLOUD_TESTS_PROJECT_ID'
2526
pubsub.set_defaults()
2627

2728

28-
class TestPubsubTopics(unittest2.TestCase):
29+
class TestPubsub(unittest2.TestCase):
2930

3031
def setUp(self):
3132
self.to_delete = []
@@ -35,21 +36,20 @@ def tearDown(self):
3536
doomed.delete()
3637

3738
def test_create_topic(self):
38-
new_topic_name = 'a-new-topic'
39-
topic = Topic(new_topic_name)
39+
TOPIC_NAME = 'a-new-topic'
40+
topic = Topic(TOPIC_NAME)
4041
self.assertFalse(topic.exists())
4142
topic.create()
4243
self.to_delete.append(topic)
4344
self.assertTrue(topic.exists())
44-
self.assertEqual(topic.name, new_topic_name)
45+
self.assertEqual(topic.name, TOPIC_NAME)
4546

4647
def test_list_topics(self):
4748
topics_to_create = [
4849
'new%d' % (1000 * time.time(),),
4950
'newer%d' % (1000 * time.time(),),
5051
'newest%d' % (1000 * time.time(),),
5152
]
52-
created_topics = []
5353
for topic_name in topics_to_create:
5454
topic = Topic(topic_name)
5555
topic.create()
@@ -58,7 +58,45 @@ def test_list_topics(self):
5858
# Retrieve the topics.
5959
all_topics, _ = pubsub.list_topics()
6060
project_id = pubsub.get_default_project()
61-
created_topics = [topic for topic in all_topics
62-
if topic.name in topics_to_create and
63-
topic.project == project_id]
64-
self.assertEqual(len(created_topics), len(topics_to_create))
61+
created = [topic for topic in all_topics
62+
if topic.name in topics_to_create and
63+
topic.project == project_id]
64+
self.assertEqual(len(created), len(topics_to_create))
65+
66+
def test_create_subscription(self):
67+
TOPIC_NAME = 'subscribe-me'
68+
topic = Topic(TOPIC_NAME)
69+
self.assertFalse(topic.exists())
70+
topic.create()
71+
self.to_delete.append(topic)
72+
SUBSCRIPTION_NAME = 'subscribing-now'
73+
subscription = Subscription(SUBSCRIPTION_NAME, topic)
74+
self.assertFalse(subscription.exists())
75+
subscription.create()
76+
self.to_delete.append(subscription)
77+
self.assertTrue(subscription.exists())
78+
self.assertEqual(subscription.name, SUBSCRIPTION_NAME)
79+
self.assertTrue(subscription.topic is topic)
80+
81+
def test_list_subscriptions(self):
82+
TOPIC_NAME = 'subscribe-me'
83+
topic = Topic(TOPIC_NAME)
84+
self.assertFalse(topic.exists())
85+
topic.create()
86+
self.to_delete.append(topic)
87+
subscriptions_to_create = [
88+
'new%d' % (1000 * time.time(),),
89+
'newer%d' % (1000 * time.time(),),
90+
'newest%d' % (1000 * time.time(),),
91+
]
92+
for subscription_name in subscriptions_to_create:
93+
subscription = Subscription(subscription_name, topic)
94+
subscription.create()
95+
self.to_delete.append(subscription)
96+
97+
# Retrieve the subscriptions.
98+
all_subscriptions, _ = pubsub.list_subscriptions()
99+
created = [subscription for subscription in all_subscriptions
100+
if subscription.name in subscriptions_to_create and
101+
subscription.topic.name == TOPIC_NAME]
102+
self.assertEqual(len(created), len(subscriptions_to_create))

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.