Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 13bf65b

Browse filesBrowse files
authored
Handle empty signature more elegantly (#312)
1 parent 76ff1ac commit 13bf65b
Copy full SHA for 13bf65b

File tree

Expand file treeCollapse file tree

2 files changed

+10
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+10
-1
lines changed
Open diff view settings
Collapse file

‎packages/gapic-generator/gapic/schema/wrappers.py‎

Copy file name to clipboardExpand all lines: packages/gapic-generator/gapic/schema/wrappers.py
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,8 @@ def flattened_fields(self) -> Mapping[str, Field]:
555555
answer: Dict[str, Field] = collections.OrderedDict(
556556
(f.strip(), self.input.get_field(*f.strip().split('.')))
557557
for sig in signatures
558-
for f in sig.split(',')
558+
# Special case for an empty signature check
559+
for f in sig.split(',') if f
559560
)
560561

561562
return answer
Collapse file

‎packages/gapic-generator/tests/unit/schema/wrappers/test_method.py‎

Copy file name to clipboardExpand all lines: packages/gapic-generator/tests/unit/schema/wrappers/test_method.py
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,14 @@ def test_method_flattened_fields():
171171
assert 'b' in method.flattened_fields
172172

173173

174+
def test_method_flattened_fields_empty_sig():
175+
a = make_field('a', type=5) # int
176+
b = make_field('b', type=5)
177+
input_msg = make_message('Z', fields=(a, b))
178+
method = make_method('F', input_message=input_msg, signatures=('',))
179+
assert len(method.flattened_fields) == 0
180+
181+
174182
def test_method_include_flattened_message_fields():
175183
a = make_field('a', type=5)
176184
b = make_field('b', type=11, message=make_message('Eggs'))

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.