Add support for Compute's operations #728

mziccard · Mar 8, 2016

This PR adds support to gcloud-java-compute for operations:

Add RegionOperationId, ZoneOperationId, GlobalOperationId classes
Add functional methods for operations to Compute's service and rpc classes
Add Operation class (with functional methods)
Add unit and integration tests

- Add RegionOperationId, ZoneOperationId, GlobalOperationId classes - Add functional methods for operations to Compute's service and rpc classes - Add Operation class (with functional methods) - Add unit and integration tests

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Compute.java

+      return new OperationFilter(checkNotNull(field), ComparisonOperator.EQ, value);
+    }
+
+    /**


ajkannan · Mar 10, 2016

Hey @mziccard, just a heads up that I haven't finished my pass yet (I'll start back up tomorrow). I'll probably be focusing more on javadocs/tests and @aozarov will be looking at the rest.

gcloud-java-compute/src/test/java/com/google/gcloud/compute/OperationTest.java

+import com.google.common.collect.ImmutableMap;
+import com.google.gcloud.compute.Operation.OperationError;
+import com.google.gcloud.compute.Operation.Status;
+import com.google.gcloud.compute.Operation.OperationWarning;


gcloud-java-compute/src/main/java/com/google/gcloud/compute/Operation.java

+   * @throws ComputeException upon failure
+   */
+  public boolean exists() throws ComputeException {
+    return reload(Compute.OperationOption.fields()) != null;


aozarov · Mar 15, 2016

Nice work. Done with first iteration.

- Add Type enum to OperationId and type() getter - Replace instanceof with switch on type() - Add better javadoc to Operation - Remove final from Operation, make hashCode and equals final

mziccard · Mar 15, 2016

Comments fixed in c41ad14 and 484071c

gcloud-java-compute/src/main/java/com/google/gcloud/compute/ComputeImpl.java

+                  ZoneOperationId zoneOperationId = (ZoneOperationId) operationId;
+                  return computeRpc.getZoneOperation(zoneOperationId.zone(),
+                      zoneOperationId.operation(), optionsMap);
+                default:


aozarov · Mar 15, 2016

Looks great! Feel free to merge without or without my latest nits.

Add support for Compute's operations

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.4.2](googleapis/java-texttospeech@v2.4.1...v2.4.2) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#725](googleapis/java-texttospeech#725)) ([87d29d3](googleapis/java-texttospeech@87d29d3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.5.0](googleapis/java-bigqueryconnection@v2.4.1...v2.5.0) (2022-08-09) ### Features * Add service_account_id output field to CloudSQL properties ([#724](googleapis/java-bigqueryconnection#724)) ([e648ac4](googleapis/java-bigqueryconnection@e648ac4)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#725](googleapis/java-bigqueryconnection#725)) ([16ac3d3](googleapis/java-bigqueryconnection@16ac3d3)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#728](googleapis/java-bigqueryconnection#728)) ([0427f34](googleapis/java-bigqueryconnection@0427f34)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.3 ([#722](googleapis/java-bigqueryconnection#722)) ([bee54b7](googleapis/java-bigqueryconnection@bee54b7)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.4 ([#723](googleapis/java-bigqueryconnection#723)) ([0df1911](googleapis/java-bigqueryconnection@0df1911)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…1575) (#728) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…nslation to v0.9.6 (#728) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-mediatranslation](https://togithub.com/googleapis/java-mediatranslation) | `0.9.5` -> `0.9.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-mediatranslation/0.9.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-mediatranslation/0.9.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-mediatranslation/0.9.6/compatibility-slim/0.9.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-mediatranslation/0.9.6/confidence-slim/0.9.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-mediatranslation).

🤖 I have created a release *beep* *boop* --- ## [0.123.18](https://togithub.com/googleapis/java-notification/compare/v0.123.17...v0.123.18) (2022-10-06) ### Dependencies * Update dependency com.google.cloud:google-cloud-pubsub-bom to v1.120.20 ([#725](https://togithub.com/googleapis/java-notification/issues/725)) ([1379a51](https://togithub.com/googleapis/java-notification/commit/1379a51ed7a52ad3966e483aea5bbac1a6c90f95)) * Update dependency com.google.cloud:google-cloud-storage to v2.13.0 ([#727](https://togithub.com/googleapis/java-notification/issues/727)) ([9b63ba7](https://togithub.com/googleapis/java-notification/commit/9b63ba7637ca5134faf1aa8a406d4b2064351940)) * Update dependency gcp-releasetool to v1.8.10 ([#726](https://togithub.com/googleapis/java-notification/issues/726)) ([f89b1e9](https://togithub.com/googleapis/java-notification/commit/f89b1e9cf69dc22fec05ccf13db1f5bfb288c0fc)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…1.3 (googleapis#728) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-game-servers).

…1.3 (googleapis#728) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-billing).

…onfig to v1.5.1 (#728)

…728) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `23.1.0` -> `24.0.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.0.0/compatibility-slim/23.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.0.0/confidence-slim/23.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging).

🤖 I have created a release *beep* *boop* --- ### [0.122.18](googleapis/java-logging-logback@v0.122.17...v0.122.18) (2022-03-30) ### Dependencies * update dependency com.google.cloud:google-cloud-logging to v3.7.3 ([#727](googleapis/java-logging-logback#727)) ([34cb2a7](googleapis/java-logging-logback@34cb2a7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

mziccard added the api: compute Issues related to the Compute Engine API. label Mar 8, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2016

mziccard force-pushed the compute branch from 961dc7a to 48f68bf Compare March 8, 2016 15:25

Add support for Compute's operations

231fe42

- Add RegionOperationId, ZoneOperationId, GlobalOperationId classes - Add functional methods for operations to Compute's service and rpc classes - Add Operation class (with functional methods) - Add unit and integration tests

mziccard force-pushed the compute branch from 48f68bf to 231fe42 Compare March 9, 2016 16:39

ajkannan reviewed Mar 10, 2016
View reviewed changes

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Compute.java

return new OperationFilter(checkNotNull(field), ComparisonOperator.EQ, value);

}

/**

This comment was marked as spam.

Sign in to view

ajkannan reviewed Mar 10, 2016
View reviewed changes

aozarov reviewed Mar 14, 2016
View reviewed changes

mziccard added 2 commits March 15, 2016 13:58

Refactor compute operations

c41ad14

- Add Type enum to OperationId and type() getter - Replace instanceof with switch on type() - Add better javadoc to Operation - Remove final from Operation, make hashCode and equals final

Remove final from immutable resource classes

484071c

mziccard force-pushed the compute branch from 0358d58 to 484071c Compare March 15, 2016 13:11

aozarov reviewed Mar 15, 2016
View reviewed changes

Operations: better javadoc for delete, stricter parsing of identities

cc29929

mziccard added a commit that referenced this pull request Mar 16, 2016

Merge pull request #728 from mziccard/compute

a4f6db9

Add support for Compute's operations

mziccard merged commit a4f6db9 into googleapis:compute-alpha Mar 16, 2016

github-actions bot pushed a commit that referenced this pull request Aug 12, 2022

chore(main): release 2.2.2 (#728)

5106fa0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

suztomo pushed a commit that referenced this pull request Feb 1, 2023

build(deps): update dependency com.google.cloud:google-cloud-shared-c…

31e3ff7

…onfig to v1.5.1 (#728)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for Compute's operations #728

Add support for Compute's operations #728

Uh oh!

mziccard commented Mar 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

ajkannan commented Mar 10, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 15, 2016

Uh oh!

mziccard commented Mar 15, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Search code, repositories, users, issues, pull requests...

Add support for Compute's operations #728

Add support for Compute's operations #728

Uh oh!

Conversation

mziccard commented Mar 8, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

ajkannan commented Mar 10, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 15, 2016

Uh oh!

mziccard commented Mar 15, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants