Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Release 0.21.1#2293

Merged
shinfan merged 2 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom
shinfan:mastershinfan/gcloud-java:masterCopy head branch name to clipboard
Jul 31, 2017
Merged

Release 0.21.1#2293
shinfan merged 2 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom
shinfan:mastershinfan/gcloud-java:masterCopy head branch name to clipboard

Conversation

@shinfan
Copy link
Contributor

@shinfan shinfan commented Jul 31, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2017
michaelbausor
michaelbausor reviewed Jul 31, 2017
View reviewed changes
Copy link
Contributor

@michaelbausor michaelbausor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 comment.

As a philosophical aside - all we are doing in this release is updating a dependency version, which suggests that it should be a patch release. But the purpose of that dependency bump is to include a new feature that will be used directly by consumers of GCJ, suggesting a minor release. I am fine with a patch release but thought I would ask...

google-cloud-contrib/google-cloud-nio-examples/README.md

```
java -cp google-cloud-contrib/google-cloud-nio/target/google-cloud-nio-0.21.1-alpha-SNAPSHOT-shaded.jar:google-cloud-contrib/google-cloud-nio-examples/target/google-cloud-nio-examples-0.21.1-alpha-SNAPSHOT.jar com.google.cloud.nio.examples.ListFilesystems
java -cp google-cloud-contrib/google-cloud-nio/target/google-cloud-nio-0.21.2-alpha-SNAPSHOT-shaded.jar:google-cloud-contrib/google-cloud-nio-examples/target/google-cloud-nio-examples-0.21.2-alpha-SNAPSHOT.jar com.google.cloud.nio.examples.ListFilesystems

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@shinfan
Copy link
Contributor Author

shinfan commented Jul 31, 2017

@lesv @garrettjonesgoogle I thought the patch release would be okay since there is no breaking change but now I want to double check with you guys.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Jul 31, 2017

I think that in the case of no new features in google-cloud-java, but updating a dependency with new features, should be a patch version bump. It's too prohibitive to do the analysis of all of the changes in dependencies and mirror the impact in google-cloud-java.

garrettjonesgoogle
garrettjonesgoogle reviewed Jul 31, 2017
View reviewed changes
pom.xml
<bigquery.version>0.21.1-beta-SNAPSHOT</bigquery.version>
<compute.version>0.21.1-alpha-SNAPSHOT</compute.version>
<contrib.version>0.21.1-alpha-SNAPSHOT</contrib.version>
<compute.version>0.21.1-alpha</compute.version>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@shinfan
Copy link
Contributor Author

shinfan commented Jul 31, 2017

@garrettjonesgoogle PTAL

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Jul 31, 2017

LGTM

@shinfan shinfan merged commit aa88a0b into googleapis:master Jul 31, 2017
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@shinfan
Release 0.21.1 (#2293)
29e6aca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neozwu neozwu Awaiting requested review from neozwu

2 more reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

@michaelbausor michaelbausor michaelbausor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shinfan @garrettjonesgoogle @michaelbausor @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.