Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat(lustre): generate library #15122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

cuiy0006
Copy link
Collaborator

@cuiy0006 cuiy0006 commented May 1, 2025

This change is Reviewable

Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (953a24d) to head (6efb9fd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15122   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files        2392     2392           
  Lines      215108   215108           
=======================================
+ Hits       199905   199911    +6     
+ Misses      15203    15197    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cuiy0006 cuiy0006 marked this pull request as ready for review May 22, 2025 15:27
@cuiy0006 cuiy0006 requested a review from a team as a code owner May 22, 2025 15:27
@cuiy0006 cuiy0006 requested a review from scotthart May 22, 2025 15:27
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a new library, we should only be updating the abi-dump for that new library.

Reviewable status: 0 of 282 files reviewed, all discussions resolved

@cuiy0006 cuiy0006 closed this May 23, 2025
@cuiy0006 cuiy0006 deleted the feat-lustre-generate-library branch May 23, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.