Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: Raise meaningful exception when oauth callback times out #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mafrosis wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

feat: Raise meaningful exception when oauth callback times out #363

mafrosis wants to merge 1 commit into from

Conversation

@mafrosis
Copy link

@mafrosis mafrosis commented Jul 8, 2024 •
edited
Loading

I found that when timeout_seconds parameter is used, the code raises an exception such as:

  File "/usr/lib/python3.12/site-packages/google_auth_oauthlib/flow.py", line 520, in run_local_server
    authorization_response = wsgi_app.last_request_uri.replace("http", "https")
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'replace'

This PR adds a custom exception such that a caller can handle this case.

I'm unable to run the full nox suite locally, but it looks like nothing has broken. I'll make any changes needed when the CI tests run.

@mafrosis mafrosis requested review from a team as code owners July 8, 2024 01:56
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 8, 2024
@mafrosis mafrosis mentioned this pull request Jul 8, 2024
Closed
@westarle westarle assigned arithmetic1728 and unassigned westarle Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arithmetic1728 arithmetic1728

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mafrosis @westarle @arithmetic1728
Morty Proxy This is a proxified and sanitized view of the page, visit original site.