Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update example in oauth2.id_token docs #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2020
Merged

Update example in oauth2.id_token docs #624

merged 2 commits into from
Oct 28, 2020

Conversation

matthewhughes934
Copy link
Contributor

Since c05b8b5 oauth2.id_token.verify_oauth2_token handles the issuer
check itself, so remove this redundant check from the docs.

@matthewhughes934 matthewhughes934 requested a review from a team as a code owner October 11, 2020 19:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2020
@matthewhughes934
docs: Update example in oauth2.id_token docs
112d737 
Since c05b8b5 oauth2.id_token.verify_oauth2_token handles the issuer
check itself, so remove this redundant check from the docs.
@matthewhughes934 matthewhughes934 force-pushed the update-oauth2-token_id-docs branch from 1dfa39e to 112d737 Compare October 11, 2020 19:10
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2020
@googleapis googleapis deleted a comment from matthewhughes934 Oct 28, 2020
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Oct 28, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9c4200d into googleapis:master Oct 28, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewhughes934 @tseaver @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.