feat: add mTLS ADC support for HTTP #453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busunkim96
reviewed
Mar 9, 2020
bshaffer
reviewed
Mar 10, 2020
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Helper functions for getting mTLS cert and key, for internal use only.""" |
There was a problem hiding this comment.
I don't think Internal use only is the right messaging here.
There was a problem hiding this comment.
what should the right messaging here?
|
Moving the code to a branch in the library instead of my forked library to avoid commit conflicts. Please see PR #457 instead. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mTLS ADC support for HTTP (AuthorizedSession and AuthorizedHttp).
go/adc-for-dca-python
Please ignore _mtls_helper.py and test__mtls_helper.py for now. These two files are duplicates (actually added one more function) of these in PR: #448. I will update these two files after that PR is submitted.