Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: always pass body of type bytes to google.auth.transport.Request #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2020
Merged

fix: always pass body of type bytes to google.auth.transport.Request #421

merged 3 commits into from
Jan 10, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jan 9, 2020 •
edited
Loading

google.auth.transport.Request says that the body should be of type bytes. Some of our code was passing in strings as reported in #318.

In practice this was not causing issues, as the two http transports requests and urllib3 are able to handle bodies passed as strings.

Closes #318

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2020
michaelawyu
michaelawyu approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@busunkim96 busunkim96 merged commit a57a770 into googleapis:master Jan 10, 2020
@yoshi-automation yoshi-automation mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelawyu michaelawyu michaelawyu approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google.auth.transport.Request is called with type(body) == str
3 participants
@busunkim96 @michaelawyu @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.