Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: Correct webauthn JSON parsing to be compliant with standard. #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

fix: Correct webauthn JSON parsing to be compliant with standard. #1658

merged 2 commits into from
Apr 14, 2025

Conversation

ikimonogakari
Copy link
Contributor

'rpid' -> 'rpId': according to the standard documentation. https://www.w3.org/TR/webauthn-3/#dom-publickeycredentialrequestoptionsjson-rpid

@ikimonogakari ikimonogakari requested review from a team as code owners January 22, 2025 16:38
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2025
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2025
@ikimonogakari ikimonogakari force-pushed the webauthn branch 3 times, most recently from 623a252 to 63e81ed Compare April 10, 2025 20:55
@sai-sunder-s sai-sunder-s added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2025
@harkamaljot harkamaljot added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2025
@harkamaljot harkamaljot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@harkamaljot harkamaljot added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 14, 2025
@harkamaljot harkamaljot merged commit 0c5ef36 into googleapis:main Apr 14, 2025
14 checks passed
@release-please release-please bot mentioned this pull request Apr 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ikimonogakari @sai-sunder-s @arithmetic1728 @harkamaljot @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.