chore: Add github action to update discovery artifacts #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2adaac to
4d02b9c
Compare
bcoe
suggested changes
Feb 19, 2021
busunkim96
reviewed
Feb 22, 2021
dbf53cc to
0a470c7
Compare
danoscarmike
approved these changes
Apr 12, 2021
This was referenced Apr 13, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
These PR add the scripts from #1187 that are needed to update discovery artifacts using a Github action. The scripts will be removed from #1187 once all of the review comments from #1187 have been resolved. This PR adds the following files under the `scripts/` folder - `README.md` to provide instructions on manually updating discovery artifacts and API reference documentation. - `buildprbody.py` creates a summary of the changes detected in discovery artifacts and writes them to `allapis.summary`. - `changesummary.py` creates verbose change information for each API with discovery artifact changes. - `createcommits.sh` creates git commits for each API with discovery artifact changes or reference document changes. - `updatediscoveryartifacts.py` is the python file that can be used to update discovery artifacts. I also moved `describe.py` under the scripts folder and modified it to save the discovery artifacts that are fetched. TODO: - [x] Add tests for scripts - [x] Address review comments in #1187
0bee0af to
82b80c6
Compare
c1a1c28 to
f88d4ee
Compare
2affa9b to
a29003e
Compare
|
@busunkim96 @tswast @SurferJeffAtGoogle @JustinBeckwith This is ready for review. PTAL |
|
@bcoe PTAL |
bcoe
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Github Actions script to copy the discovery artifacts from googleapis/discovery-artifact-manager and create a PR which summarizes the changes.
PR #1286 contains the scripts that the Github Action will use.