Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Modify noxfile to build and test the package #1235

Copy link
Copy link
Closed
@parthea

Description

@parthea
Issue body actions

Versions 2.0.0 and 2.0.1 were yanked from PyPI last week due to an issue where discovery documents were not included in the published package causing discovery.build() to fail(#1214). A basic check could be added to verify the package works correctly using the steps in #1214. Ideally it should be done on every PR and push to master so the issue can be caught before the package is published.

Use these steps from #1214 to re-produce the issue with version 2.0.0 and 2.0.1:

  1. Start with a clean clone of google-api-python-client
  2. Checkout version 2.0.0 or 2.0.1, using git checkout 2.0.0
  3. Run python setup.py sdist
  4. Run pip install dist/google-api-python-client-<version>.tar.gz
  5. Run
$ python3
Python 3.8.7 (default, Jan 27 2021, 18:44:05) 
[GCC 10.2.1 20201224] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from googleapiclient import discovery
>>> client = discovery.build("cloudprofiler", "v2")
...

Before closing this issue, we should ensure that we have checks in place so that a PR will fail if package_data here is empty.

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.This issue needs some love.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.