This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: Repair broken test on Node 20 #1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
=======================================
Coverage 61.72% 61.72%
=======================================
Files 17 17
Lines 1309 1309
Branches 257 257
=======================================
Hits 808 808
Misses 447 447
Partials 54 54 ☔ View full report in Codecov by Sentry. |
haroonc
approved these changes
Feb 1, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
🤖 I have created a release *beep* *boop* --- ## [9.0.1](https://togithub.com/googleapis/cloud-debug-nodejs/compare/v9.0.0...v9.0.1) (2024-02-01) ### Bug Fixes * Repair broken test on Node 20 ([#1193](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1193)) ([a600ea8](https://togithub.com/googleapis/cloud-debug-nodejs/commit/a600ea8f7868a852d47ba485c0d49864339eb072)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are currently broken on Node 20 due to a change in behaviour. A field that we expected to have present in breakpoints is no longer set. This fix removes that check in order to get the test to pass again; it is not currently worth the effort to investigate the cause of the change as it has no meaningful effect on the debug agent.