Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Conversation

@mctavish
Copy link
Contributor

@mctavish mctavish commented May 31, 2023

After this change, all agents will use the firebase backend.

Docs will be updated separately.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1143 🦕

@mctavish mctavish requested review from a team as code owners May 31, 2023 14:24
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels May 31, 2023
@mctavish mctavish marked this pull request as draft May 31, 2023 14:29
@mctavish mctavish added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@mctavish mctavish added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@mctavish mctavish added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 31, 2023
@mctavish mctavish added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2023
@mctavish mctavish marked this pull request as ready for review May 31, 2023 20:28
@mctavish mctavish added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -18.77 ⚠️

Comparison is base (c292200) 73.27% compared to head (5c85379) 54.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1144       +/-   ##
===========================================
- Coverage   73.27%   54.51%   -18.77%     
===========================================
  Files          20       18        -2     
  Lines        1624     1495      -129     
  Branches      319      290       -29     
===========================================
- Hits         1190      815      -375     
- Misses        347      626      +279     
+ Partials       87       54       -33     
Impacted Files Coverage Δ
src/agent/debuglet.ts 9.84% <0.00%> (-68.52%) ⬇️
src/agent/firebase-controller.ts 64.75% <0.00%> (-1.08%) ⬇️
src/debuggee.ts 57.14% <ø> (-19.05%) ⬇️
src/index.ts 30.43% <0.00%> (-47.35%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mctavish mctavish merged commit 7ed8fb2 into googleapis:main Jun 5, 2023
@mctavish mctavish deleted the firebase-dev branch June 5, 2023 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove support for deprecated Cloud Debugger API

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.