Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Conversation

@mctavish
Copy link
Contributor

A significant number of dependencies have dropped support for Node 10, so this package will follow suit.

@mctavish mctavish requested review from a team as code owners May 16, 2022 20:37
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. labels May 16, 2022
@mctavish mctavish requested a review from bcoe May 16, 2022 20:37
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1082 (3c8ac75) into main (d6eb886) will decrease coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
- Coverage   66.11%   65.77%   -0.35%     
==========================================
  Files          21       21              
  Lines        1750     1750              
  Branches      352      352              
==========================================
- Hits         1157     1151       -6     
- Misses        510      512       +2     
- Partials       83       87       +4     
Impacted Files Coverage Δ
src/agent/state/inspector-state.ts 89.35% <0.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6eb886...3c8ac75. Read the comment docs.

@mctavish
Copy link
Contributor Author

Closing this. #1084 does it better.

@mctavish mctavish closed this May 18, 2022
@mctavish mctavish deleted the node12 branch May 18, 2022 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.