Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

richieforeman
Copy link
Member

@richieforeman richieforeman commented Oct 13, 2025

TLDR

Update release workflows to use environment vars for package names, tokens and things. Expose this option in release-manual, default environment=prod in all other release flows. Follow on work is iterated on below.

Dive Deeper

Walk thru

  • Add a composite action to return the appropriate auth token for a given package name
  • Add a composite action to properly setup the .npmrc file.
  • Update publish-release/action.yml to accept package names and token via variables
  • Update workflows/verify-release.yml to handle environment variables (this is not used for the release process, and is instead for manual testing)
  • Update all workflows that use publish-release/action.yml to:
    • To. specify the new env vars (cli-package-name, etc, etc)
    • Specify an environment for each task
    • For release-manual.yml: Add an option to specify dev vs prod
    • For all other releases (nightly, etc, etc): Fix the option to prod, add a TODO around adding plumbing for this.

Odd things / Issues / Future cleanup

NOTE: Pending this review, I will file all the pending things as tickets that I think are easily digestible.

  • There is a script that preps the github launch. I opted to just conditional this. I think this can be generalized in a more focused follow up (Potential irony, I anticipated this @ Update verify release workflow to account for different registries #10452)
  • A2A package was failing to deploy to GH NPM Registry. For the moment I conditioned this to only only push when the
    package name is for PROD. In the immediate term, I think this can be fixed. (It seems that A2A publishing was rollback anyway, lolz. ref: Revert "chore: wire a2a-server up for publishing" #11064 )
  • I need to add in the prod vs dev switch to each of the other release actions. This is easy enough, but I wanted to document this and communicate it before I make that change. I think it's best as a separate cl.
  • release rollback workflow needs some serious updating to adhere to this. Notably, get-release-version.js needs updating to accept dynamic package names. This will allow the rollback action to potentially work with the dev repo

Reviewer Test Plan

Dev Run

I ran manual-release w/ (tag=0.0.666 && target=dev && env=dev)

➜  gemini-cli git:(rf/env) npm dist-tags @google-gemini/gemini-cli
dev: 0.0.666
false: 0.0.666
meow: 0.0.777777777777
test: 0.0.777777777777

PROD RUN

I ran manual release w/ (tag=0.0.77777776 && target=dev && env=dev)

➜  gemini-cli git:(rf/env) npm dist-tags @google/gemini-cli
bundle: 0.0.44-beta.0
dev: 0.0.77777776
false: 0.0.77777776
latest: 0.8.2
nightly: 0.10.0-nightly.20251013.cfb71b9d
preview: 0.9.0-preview.2

Others

➜  gemini-cli git:(rf/env) npm dist-tags ls @google-gemini/gemini-cli
dev: 0.0.6
false: 0.0.666
meow: 0.0.777777777777
test: 0.0.777777777777

Linked issues / bugs

#10003

Copy link

github-actions bot commented Oct 14, 2025

Size Change: +7.07 kB (+0.04%)

Total Size: 17.8 MB

Filename Size Change
./bundle/gemini.js 17.8 MB +7.07 kB (+0.04%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 830 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

@richieforeman richieforeman marked this pull request as ready for review October 14, 2025 01:22
@richieforeman richieforeman requested review from a team as code owners October 14, 2025 01:22
@richieforeman richieforeman changed the title DRAFT: Update release to use env variables. feat(ci): Update release to use github env variables. Oct 14, 2025
@google-gemini google-gemini deleted a comment from github-actions bot Oct 14, 2025
Copy link
Collaborator

@mattKorwel mattKorwel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richieforeman I'm approving these. I know @skeshive is looking to roll out releases today. I'll look to you to be on watch to support her in that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.