fix(patch): cherry-pick 0a7ee67 to release/v0.8.2-pr-10900 to patch version v0.8.2 and create version 0.8.3 #11014
Conversation
Summary of ChangesHello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cherry-picks a commit to introduce enhanced screen reader accessibility for the CLI. It adds a new configuration option to enable a screen reader-friendly plaintext view, sets its default value, and provides a clear in-app notification to users when this mode is active, guiding them on how to manage the setting. This change is being applied as a patch to version Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a screen reader accessibility mode. The changes include adding the new configuration option to the documentation and settings schema, and implementing a notification to inform the user when this mode is active. My review focuses on improving the user-facing notification message to be more accurate and helpful.
| <Text> | ||
| You are currently in screen reader-friendly view. To switch out, open{' '} | ||
| {settingsPath} and remove the entry for {'"screenReader"'}. | ||
| </Text> |
There was a problem hiding this comment.
The notification provides potentially misleading instructions for disabling screen reader mode. It assumes the setting is configured in the user's global settings.json file and suggests removing the entry.
However, the setting could be enabled through other configuration files (project, system), environment variables, or command-line flags, per the CLI's configuration layering. This message could confuse users if the setting is not in the specified file. Additionally, the recommended action should be to set the value to false rather than removing the entry, which is more explicit and reliable.
A more general instruction would be more accurate. With the suggested change, the settingsPath constant and its related imports (homedir, path) will no longer be needed in this file and can be removed.
<Text>
You are currently in screen reader-friendly view. To disable this mode, set `ui.accessibility.screenReader` to `false` in your Gemini CLI configuration.
</Text>
|
Size Change: +538 B (0%) Total Size: 17.6 MB ℹ️ View Unchanged
|
This PR automatically cherry-picks commit 0a7ee67 to patch version v0.8.2 in the stable release to create version 0.8.3.