Support datetime expressions in weather-sp output templates#536
Open
zeel2104 wants to merge 1 commit intogoogle:maingoogle/weather-tools:mainfrom
zeel2104:fix-weather-sp-datetime-template-535zeel2104/weather-tools:fix-weather-sp-datetime-template-535Copy head branch name to clipboard
Open
Support datetime expressions in weather-sp output templates#536zeel2104 wants to merge 1 commit intogoogle:maingoogle/weather-tools:mainfrom zeel2104:fix-weather-sp-datetime-template-535zeel2104/weather-tools:fix-weather-sp-datetime-template-535Copy head branch name to clipboard
zeel2104 wants to merge 1 commit intogoogle:maingoogle/weather-tools:mainfrom
zeel2104:fix-weather-sp-datetime-template-535zeel2104/weather-tools:fix-weather-sp-datetime-template-535Copy head branch name to clipboard
Conversation
Collaborator
|
@zeel2104, can you please fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #535.
Adds support for richer Python-style expressions in
weather-spoutput templates, including datetime formatting expressions like{datetime.strptime(f"{time}", "%H%M").strftime("%H:%M:%S")}.This allows an output template such as:
gs://test-output/splits/test-file_{date}-{datetime.strptime(f"{time}", "%H%M").strftime("%H:%M:%S")}.gribto produce:
gs://test-output/splits/test-file_20200101-12:00:00.gribChanges
OutFileInfo.time, are included.GribSplitterV2to use raw split-dimension temp filenames forgrib_copy, then apply the richer Python formatter during upload.Testing
Manual validation passed:
['date', 'time']gs://test-output/splits/test-file_20200101-12:00:00.gribFull pytest was not run locally because this Windows Python 3.14 environment is missing
pygrib/ecCodes support.