Skip logging queries#296
Open
artamonovkirill wants to merge 1 commit intogoogle:mastergoogle/sqlcommenter:masterfrom
Open
Skip logging queries#296artamonovkirill wants to merge 1 commit intogoogle:mastergoogle/sqlcommenter:masterfrom
artamonovkirill wants to merge 1 commit intogoogle:mastergoogle/sqlcommenter:masterfrom
Conversation
Fixes google#287 CursorDebugWrapper already adds an entry to the queries_log post-execution: https://github.com/django/django/blob/main/django/db/backends/utils.py#L145-L150
artamonovkirill
commented
Jan 8, 2026
| # * https://github.com/basecamp/marginalia/pull/80 | ||
|
|
||
| # Add the query to the query log if debugging. | ||
| if isinstance(context['cursor'], CursorDebugWrapper): |
Author
There was a problem hiding this comment.
If you'd prefer explicit control over the log entry, we could update it instead:
if isinstance(context['cursor'], CursorDebugWrapper):
context['connection'].queries_log[-1]['sql'] = sqlThis shouldn't be necessary anyway—since we modify the SQL before calling execute(), Django's logging already captures the commented version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #287
CursorDebugWrapperalready adds an entry to the queries_log post-execution: https://github.com/django/django/blob/main/django/db/backends/utils.py#L145-L150