Correct application tags for compatibility with CloudSQL#292
Open
mbrancato wants to merge 4 commits intogoogle:mastergoogle/sqlcommenter:masterfrom
mbrancato:correct_query_insights_tagsmbrancato/sqlcommenter:correct_query_insights_tagsCopy head branch name to clipboard
Open
Correct application tags for compatibility with CloudSQL#292mbrancato wants to merge 4 commits intogoogle:mastergoogle/sqlcommenter:masterfrom mbrancato:correct_query_insights_tagsmbrancato/sqlcommenter:correct_query_insights_tagsCopy head branch name to clipboard
mbrancato wants to merge 4 commits intogoogle:mastergoogle/sqlcommenter:masterfrom
mbrancato:correct_query_insights_tagsmbrancato/sqlcommenter:correct_query_insights_tagsCopy head branch name to clipboard
Conversation
rushilsrivastava
added a commit
to SimplifyJobs/sqlcommenter
that referenced
this pull request
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a long outstanding bug where application is not properly tagged for some Python middleware. The tag was incorrectly set as
app_nameinstead ofapplicationcausing them not to be displayed in Google CloudSQL query insights.https://cloud.google.com/sql/docs/mysql/using-query-insights#using-sql-commenter