Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add support for gRPC java#244

Open
shubhwip wants to merge 1 commit intogoogle:mastergoogle/sqlcommenter:masterfrom
shubhwip:feature/grpc_support_243shubhwip/sqlcommenter:feature/grpc_support_243Copy head branch name to clipboard
Open

Add support for gRPC java#244
shubhwip wants to merge 1 commit intogoogle:mastergoogle/sqlcommenter:masterfrom
shubhwip:feature/grpc_support_243shubhwip/sqlcommenter:feature/grpc_support_243Copy head branch name to clipboard

Conversation

@shubhwip
Copy link
Contributor

@shubhwip shubhwip commented Apr 8, 2023

closes #243

Important Notes :

  • Had to upgrade gradle from 4.9 to 5.6 to add gRPC dependencies which led to some changes in plugins declaration in gradle build file.
  • Not sure how to keep these compiler flags with new gradle version as didn't find documentation for these flags anywhere
    it.options.compilerArgs += ["-XepAllDisabledChecksAsWarnings", "-XepDisableWarningsInGeneratedCode"]
    it.options.compilerArgs += ["-Xep:MutableMethodReturnType:OFF"]
    it.options.compilerArgs += ["-Xep:ReturnMissingNullable:OFF"]
    it.options.compilerArgs += ["-Xep:Var:OFF"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SQL commenter for gRPC Web Services

1 participant

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.