Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Always escape values in comments as per specification#217

Merged
sjs994 merged 2 commits intogoogle:mastergoogle/sqlcommenter:masterfrom
kostyay:AlwaysEscapeValueskostyay/sqlcommenter:AlwaysEscapeValuesCopy head branch name to clipboard
Dec 15, 2022
Merged

Always escape values in comments as per specification#217
sjs994 merged 2 commits intogoogle:mastergoogle/sqlcommenter:masterfrom
kostyay:AlwaysEscapeValueskostyay/sqlcommenter:AlwaysEscapeValuesCopy head branch name to clipboard

Conversation

@kostyay
Copy link
Contributor

@kostyay kostyay commented Dec 15, 2022

Fixes #216

Copy link
Contributor

@sjs994 sjs994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !

@sjs994 sjs994 merged commit 0579a4a into google:master Dec 15, 2022
@kostyay kostyay deleted the AlwaysEscapeValues branch December 15, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go: Incorrect specification implementation causes traceparent not to work properly

2 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.