Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

go sqlcommenter docs#200

Merged
kapv89 merged 1 commit intogh-pagesgoogle/sqlcommenter:gh-pagesfrom
go/gh-pagesgoogle/sqlcommenter:go/gh-pagesCopy head branch name to clipboard
Dec 2, 2022
Merged

go sqlcommenter docs#200
kapv89 merged 1 commit intogh-pagesgoogle/sqlcommenter:gh-pagesfrom
go/gh-pagesgoogle/sqlcommenter:go/gh-pagesCopy head branch name to clipboard

Conversation

@kapv89
Copy link
Contributor

@kapv89 kapv89 commented Dec 2, 2022

No description provided.

@kapv89
Copy link
Contributor Author

kapv89 commented Dec 2, 2022

Screen Shot 2022-12-02 at 1 49 16 PM

Screen Shot 2022-12-02 at 1 49 21 PM

Screen Shot 2022-12-02 at 1 49 29 PM

Screen Shot 2022-12-02 at 1 49 36 PM

Screen Shot 2022-12-02 at 1 49 42 PM

Screen Shot 2022-12-02 at 1 49 46 PM

Screen Shot 2022-12-02 at 1 49 53 PM

Copy link
Contributor

@sjs994 sjs994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added few comments. Do resolve them before merging. Thanks !

src/content/go/database_sql/_index.md Show resolved Hide resolved
src/content/go/database_sql/_index.md Show resolved Hide resolved
src/content/go/database_sql/_index.md Show resolved Hide resolved
func runApp() {
r := mux.NewRouter()
r.Use(sqlcommentermux.SQLCommenterMiddleware)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove the empty lines in embedded code to make the vertical length more compact.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think vertical lines help with readability in docs too

@kapv89 kapv89 merged commit d73228f into gh-pages Dec 2, 2022
@kapv89
Copy link
Contributor Author

kapv89 commented Dec 2, 2022

Merged without seeing comments, will raise another pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.