Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Code structure Refactoring#162

Open
Thiyagu55 wants to merge 28 commits intogoogle:mastergoogle/sqlcommenter:masterfrom
Thiyagu55:go-sql-implementationThiyagu55/sqlcommenter:go-sql-implementationCopy head branch name to clipboard
Open

Code structure Refactoring#162
Thiyagu55 wants to merge 28 commits intogoogle:mastergoogle/sqlcommenter:masterfrom
Thiyagu55:go-sql-implementationThiyagu55/sqlcommenter:go-sql-implementationCopy head branch name to clipboard

Conversation

@Thiyagu55
Copy link
Contributor

@Thiyagu55 Thiyagu55 commented Sep 30, 2022

Added 3 seperate modules for core,http/net & go-sql-driver
Added ReadMe for all the modules

Thiyagu55 and others added 24 commits September 19, 2022 16:56
@Thiyagu55
Added support for Query Row and Query Context
3b5a535
@Thiyagu55
Added support for http-router
f9b7cad
@Thiyagu55
Go-SQL Implementation done
0cc3b08
@Thiyagu55
Added README.md & copyright header
373142d
@Thiyagu55
Updated net/http
d61b985
@sjs994
Update README.md
f89b7b3
@sjs994
Update go-sql.go
dc6c518
@Thiyagu55
Added support for otel traceparet
f7eb636
@Thiyagu55
PR changes for otel integration
935870f
@Thiyagu55
Added Unittests
5ac9c42
@Thiyagu55
PR changes
5ff4995
@Thiyagu55
PR changes
1ef9f62
@Thiyagu55
Added CI unittest pipeline
f79cf94
@Thiyagu55
Added CI unittest pipeline
3327a3b
@Thiyagu55
Added sqlmock module
9749f6b
@Thiyagu55
Added CI unittest pipeline
4b5cebc
@Thiyagu55
Added gofmt tests
c347efb
@Thiyagu55
Added gofmt tests
f27540a
@Thiyagu55
Rename Package
50e7ffd
@Thiyagu55
updated github workflow
6ce058a
@Thiyagu55
updated github workflow
50aff88
@Thiyagu55
renamed github workflow
266ff1e
@Thiyagu55
Code structure refactoring
ec74286
@Thiyagu55
Merge branch 'go-sql-implementation' of https://github.com/Thiyagu55/…
c328bbb 
…sqlcommenter into go-sql-implementation
@Thiyagu55 Thiyagu55 requested a review from sjs994 September 30, 2022 06:30
sjs994
sjs994 reviewed Sep 30, 2022
View reviewed changes
go/core/core.go Outdated Show resolved Hide resolved
go/core/core.go Outdated Show resolved Hide resolved
go/go-sql/.vscode/launch.json Outdated Show resolved Hide resolved
go/http-net/http-net.go Outdated Show resolved Hide resolved
go/go-sql/README.md Outdated Show resolved Hide resolved
@sjs994
Copy link
Contributor

sjs994 commented Sep 30, 2022

Can the sample application also be checked in as part of another child folder under "go".
Something like:

go
--> samples
----> http-sql-sample
--> core
--> go-sql
--> http-net

@Thiyagu55
Copy link
Contributor Author

Thiyagu55 commented Sep 30, 2022

http-sql-sample

Added sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sjs994 sjs994 sjs994 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Thiyagu55 @sjs994

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.