Return a non-zero exit code upon error#848
Closed
abstractlyZach wants to merge 2 commits intogoogle:mastergoogle/google-java-format:masterfrom
abstractlyZach:return_nonzeroabstractlyZach/google-java-format:return_nonzeroCopy head branch name to clipboard
Closed
Return a non-zero exit code upon error#848abstractlyZach wants to merge 2 commits intogoogle:mastergoogle/google-java-format:masterfrom abstractlyZach:return_nonzeroabstractlyZach/google-java-format:return_nonzeroCopy head branch name to clipboard
abstractlyZach wants to merge 2 commits intogoogle:mastergoogle/google-java-format:masterfrom
abstractlyZach:return_nonzeroabstractlyZach/google-java-format:return_nonzeroCopy head branch name to clipboard
Conversation
This brings us in line with the Unix standard of returning non-zero for a failed command: https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html Also, this will allow any callers (like google-format-java-diff.py) to respond appropriately.
tbroyer
reviewed
Oct 19, 2022
cushon
approved these changes
Jan 14, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 16, 2023
This brings us in line with the Unix standard of returning non-zero for a failed command: https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html Also, this will allow any callers (like google-java-format-diff.py) to respond appropriately. [A change](http://r.android.com/2257232) needed to be reverted because `google-java-format-diff.py` was failing silently, so the author wasn't aware that their change caused a pre-upload hook to stop working. Fixes #848 FUTURE_COPYBARA_INTEGRATE_REVIEW=#848 from abstractlyZach:return_nonzero 06b2d36 PiperOrigin-RevId: 502211842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings us in line with the Unix standard of returning non-zero for a failed command:
https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html
Also, this will allow any callers (like google-java-format-diff.py) to respond appropriately.
A change needed to be reverted because
google-java-format-diff.pywas failing silently, so the author wasn't aware that their change caused a pre-upload hook to stop working.