This repository was archived by the owner on Jun 4, 2021. It is now read-only.
Switch to using module-level loggers#164
Open
fahhem wants to merge 1 commit intogoogle:mastergoogle/containerregistry:masterfrom
Open
Switch to using module-level loggers#164fahhem wants to merge 1 commit intogoogle:mastergoogle/containerregistry:masterfrom
fahhem wants to merge 1 commit intogoogle:mastergoogle/containerregistry:masterfrom
Conversation
Author
|
Test seems to have failed due to tooling issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have notifications setup on all logging.errors, but we don't want to be notified for retries (we will be notified if the retries fail, as it still raises an exception). By switching to a non-root logger, it allows us to disable notifications on this particular logger, but doesn't change the default behavior.