fix: race condition while appending Agent's events to SessionService#715
Open
copybara-service[bot] wants to merge 1 commit intomaingoogle/adk-java:mainfrom
Open
fix: race condition while appending Agent's events to SessionService#715copybara-service[bot] wants to merge 1 commit intomaingoogle/adk-java:mainfrom
copybara-service[bot] wants to merge 1 commit intomaingoogle/adk-java:mainfrom
Conversation
Agent events were processed by agentEvents.flatMap(e -> session.appendEvent(e)), which has no ordering guarantees, so the events could have been appended to session out of order. PiperOrigin-RevId: 853618840
b7e0772 to
44f3efc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: race condition while appending Agent's events to SessionService
Agent events were processed by agentEvents.flatMap(e -> session.appendEvent(e)), which has no ordering guarantees, so the events could have been appended to session out of order.