refactor: Simplifying TestUtils#544
Merged
copybara-service[bot] merged 1 commit intomaingoogle/adk-java:mainfrom Oct 24, 2025
Merged
refactor: Simplifying TestUtils#544copybara-service[bot] merged 1 commit intomaingoogle/adk-java:mainfrom
copybara-service[bot] merged 1 commit intomaingoogle/adk-java:mainfrom
Conversation
168855e to
f866950
Compare
Basically, the single Event case and multi-Event case had duplicate code. I consolidated the implementation, and broke down different parts of the process into helper methods. PiperOrigin-RevId: 823580027
f866950 to
091275f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: Simplifying TestUtils
Basically, the single Event case and multi-Event case had duplicate code. I consolidated the implementation, and broke down different parts of the process into helper methods.